Simplify random access iterator advancement #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes a minor error in a nearby comment. |
niermann999
approved these changes
Dec 9, 2024
stephenswat
force-pushed
the
perf/simplify_advance
branch
from
2ae1d0d to
054f5d1
Compare
I was surprised while profiling the detray code but a surprisingly large amount of time is spent in the random access iterator advance function. This is somewhat inefficiently implemented as it is full of if statements. I have decided to simplify the function, which leads to a small but noticeable performance improvement of around 4% in the detray benchmarks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised while profiling the detray code to find that a surprisingly large amount of time is spent in the random access iterator advance function. This is somewhat inefficiently implemented as it is full of if statements. I have decided to simplify the function, which leads to a small but noticeable performance improvement of around 4% in the detray benchmarks.