ODD CUDA Reconstruction, main branch (2024.04.23.) #552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the last ~2 weeks of developments, full-chain ODD reconstruction with CUDA is finally here. 🥳
Unfortunately it's not quite as perfect just yet as it should be. 😦
In order to get the code running, I had to generalize
traccc::cuda::finding_algorithm
a little. It was not exercised with a resizable measurement buffer so far, so it was doing an invalid access when I gave it a resizable container. (I had to deal with exactly this in #545 and #550 already, so it didn't take long to find the issue...)Other than that, I "just" had to update
seq_example_cuda.cpp
to add track finding and track fitting to it. 🤔 With this PR's code, I now get:The excellent news is that the code techically runs. 😁 But CUDA finds way fewer tracks than the host does. And even the ones that it finds, have quite different fitted parameters than the ones found by the CPU. 🤔
@beomki-yeo, I hope that some of it is "just" due to some mistake I'm doing with some sort of configuration parameter. But I'll need some help. 😉