Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-fetch in the API to fix connection drop issue #1397

Merged
merged 13 commits into from
Jul 29, 2023
Merged

Update node-fetch in the API to fix connection drop issue #1397

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c20a8fd
Add yet more error logging
j-f1 Jul 24, 2023
09a2437
Add release note
j-f1 Jul 24, 2023
e6d3ae0
Update to node-fetch 3
j-f1 Jul 25, 2023
e2a9329
ignore API stats.json file
j-f1 Jul 25, 2023
f0902ec
Update release note
j-f1 Jul 25, 2023
fbdc5af
Remove unused fetchBinary
j-f1 Jul 25, 2023
de09fca
Fix require() of esm error
j-f1 Jul 25, 2023
553b585
Fix import() transform
j-f1 Jul 25, 2023
9486ef1
swap self for globalThis
j-f1 Jul 27, 2023
24d8d7e
Add build:api global script
j-f1 Jul 27, 2023
2111a85
Fix api/test.js
j-f1 Jul 27, 2023
74db110
Fix lint error
j-f1 Jul 27, 2023
2f6e090
Delete test.js
j-f1 Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/loot-core/src/server/cloud-storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,10 +399,15 @@ export async function download(fileId) {
},
});
} catch (err) {
console.log('Error fetching file info', err);
throw FileDownloadError('internal', { fileId });
}

if (res.status !== 'ok') {
console.log(
'Could not download file from the server. Are you sure you have the right file ID?',
res,
);
throw FileDownloadError('internal', { fileId });
}
let fileData = res.data;
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/1397.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Enhancements
authors: [j-f1]
---

Improve error messaging when the API package fails to download a file