Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sinon-chrome doesn't support promises for async functions #101

Open
faameunier opened this issue Jul 22, 2020 · 0 comments
Open

sinon-chrome doesn't support promises for async functions #101

faameunier opened this issue Jul 22, 2020 · 0 comments

Comments

@faameunier
Copy link

Hi,

Something along the lines of

browser.browserAction.getBadgeText({}).then(() => {})

will fail as getBadgeText return undefined instead of a promise (which is a supported way to work with the webExtension API).

As a side note, I tried to implement a fix for #94 but it fails due to properties ref and the code is a bit too obscure for me on that part haha.

Thanks !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@faameunier