Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update script and update Firefox schemas to 84 #94

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ariasuni
Copy link

@ariasuni ariasuni commented Oct 4, 2019

Fix #63
Fix #87
Fix #89

I took the script at #73 and converted it to Python 3.

Right now I have 18 tests failed with two different types of failures, but I don’t know how to fix them:

  1) webextensions webextensions browser.menus webextensions browser.menus.create should be defined:
     AssertionError: expected false to be truthy
      at Function.assert.isOk (node_modules/chai/lib/chai/interface/assert.js:85:32)                                                                                                                                                   
      at Context.<anonymous> (test/specs/chrome.methods.test.js:36:20)                                                                                                                                                                 
      at processImmediate (internal/timers.js:439:21)                                                                                                                                                                                  

  2) webextensions webextensions browser.menus webextensions browser.menus.create should have stub sync behaviour:
     TypeError: Cannot read property 'resetHistory' of undefined
      at Context.<anonymous> (test/specs/chrome.methods.test.js:42:18)                                                                                                                                                                 
      at processImmediate (internal/timers.js:439:21)                                 

This may be related to the fact that there is three times webextensions in the test name, because they are apparently the only tests to have that.

@acvetkov
Copy link
Owner

acvetkov commented Jan 9, 2020

This may be related to the fact that there is three times webextensions in the test name, because they are apparently the only tests to have that.

@ariasuni Hi, sorry for LOOOOOONG time answer and thank you for pr (it's very useful).
I think problem is related to the fact that there is several namespace declarations in the new stable-api-ff.json and every next declaration clear previous data.

Unfortunately, I can not accept this pr, until you fix this problem, because new schema breaks sinon-chrome webextension api.

I think, solution is very simple - check this place. You should check is this namespace was already defined before override it.

@ariasuni
Copy link
Author

  • Complete rework of the script for downloading Firefox schemas (notably, correctly deep merge schemas)
  • Update supported APIs in the readme (several were invalid, a lot were missing)
  • Update config for Firefox tests by reviewing manually all «Changes for add-on developers» (e.g. here)

I still have two errors that I didn’t find how to fix:

  1) webextensions webextensions browser.devtools.panels webextensions browser.devtools.panels.elements should return specified value:
     AssertionError: expected { Object (createSidebarPane, onSelectionChanged) } to equal 'a'
      at Context.<anonymous> (test/specs/chrome.properties.test.js:49:20)
      at processImmediate (node:internal/timers:463:21)

  2) webextensions webextensions browser.devtools.panels webextensions browser.devtools.panels.elements should return default value on flush:
     AssertionError: expected { Object (createSidebarPane, onSelectionChanged) } to equal 'value'
      at Context.<anonymous> (test/specs/chrome.properties.test.js:57:20)
      at processImmediate (node:internal/timers:463:21)

@ariasuni ariasuni changed the title Add update script and update Firefox schemas to 69 Add update script and update Firefox schemas to 84 Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants