Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Path Search Feature to Qlever #1335

Open
wants to merge 102 commits into
base: master
Choose a base branch
from

Conversation

JoBuRo
Copy link
Contributor

@JoBuRo JoBuRo commented Apr 30, 2024

This PR will add a feature for performing path-search in Qlever. It can be called via Federated Query. Currently, there are two different algorithms for computing paths: one for the computation of all paths and one to compute all shortest paths. The PathSearch is designed in such a way, that adding more algorithms later is straightforward.

@JoBuRo
Copy link
Contributor Author

JoBuRo commented Apr 30, 2024

Current TODOs:

  • Implement federated query parsing for path search
  • Improve estimates of the PathSearch operation
  • Check if building the ResultTable can be improved
  • Refactor PathSearch into smaller classes

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 90.37657% with 46 lines in your changes missing coverage. Please review.

Project coverage is 88.49%. Comparing base (414f50c) to head (aa632a1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/engine/QueryPlanner.cpp 75.34% 11 Missing and 7 partials ⚠️
src/engine/PathSearch.cpp 94.38% 6 Missing and 9 partials ⚠️
src/parser/GraphPatternOperation.cpp 88.88% 5 Missing and 6 partials ⚠️
src/engine/CheckUsePatternTrick.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1335      +/-   ##
==========================================
+ Coverage   88.39%   88.49%   +0.10%     
==========================================
  Files         362      364       +2     
  Lines       27435    27927     +492     
  Branches     3706     3802      +96     
==========================================
+ Hits        24251    24715     +464     
- Misses       1943     1960      +17     
- Partials     1241     1252      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JoBuRo JoBuRo marked this pull request as ready for review June 26, 2024 07:33
@JoBuRo JoBuRo requested a review from joka921 October 4, 2024 16:25
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, we'll try this out today.

Copy link

sonarcloud bot commented Oct 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants