Restore old size calculation behaviour #1462

RobinTF · 2024-08-24T13:33:26Z

See #1455 for details

RobinTF · 2024-08-24T13:45:31Z

src/engine/ExportQueryExecutionTrees.cpp

@@ -705,15 +705,16 @@ nlohmann::json ExportQueryExecutionTrees::computeQueryResultAsQLeverJSON(
  j["runtimeInformation"]["meta"] = nlohmann::ordered_json(
      qet.getRootOperation()->getRuntimeInfoWholeQuery());
  RuntimeInformation runtimeInformation = qet.getRootOperation()->runtimeInfo();
+
+  size_t resultSize = runtimeInformation.numRows_;
+


Important Note: For lazy results the "total count" with this change will mean absolutely nothing when the outermost operation doesn't support limits. In this case it will just mean how many rows there would've been if the last (and first with offset) block would've been sent too. So in the current code state this will never be higher than j["res"].size() + 2 * index block size

codecov · 2024-08-24T14:19:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (309f6b7) to head (ec2ae0c).
Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1462      +/-   ##
==========================================
+ Coverage   88.41%   89.45%   +1.04%     
==========================================
  Files         362      366       +4     
  Lines       27426    34402    +6976     
  Branches     3705     4115     +410     
==========================================
+ Hits        24248    30776    +6528     
- Misses       1943     2397     +454     
+ Partials     1235     1229       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.