Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial join bounding box #1546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jonathan24680
Copy link
Collaborator

This pull request adds an efficient algorithm for the SpatialJoin Class, which handles queries like this:

SELECT * WHERE {
?a .
?b .
?a max-distance-in-meters:100 ?b
}

until now, the algorithm compared all pairs, which needed quadratic time. The pull request adds an improved algorithm, which uses bounding boxes, to eliminate many candidates without the need to check them separately.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 89.09091% with 24 lines in your changes missing coverage. Please review.

Project coverage is 88.96%. Comparing base (2b4e6b3) to head (e9ed3e4).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/engine/SpatialJoinAlgorithms.cpp 88.94% 15 Missing and 7 partials ⚠️
src/engine/SpatialJoin.cpp 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1546      +/-   ##
==========================================
+ Coverage   88.93%   88.96%   +0.02%     
==========================================
  Files         364      367       +3     
  Lines       33127    33470     +343     
  Branches     3715     3769      +54     
==========================================
+ Hits        29462    29777     +315     
- Misses       2433     2456      +23     
- Partials     1232     1237       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sparql-conformance
Copy link

Copy link

sonarcloud bot commented Oct 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant