Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the implementation of the SpatialJoin operation into a separate class #1552

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

Jonathan24680
Copy link
Collaborator

@Jonathan24680 Jonathan24680 commented Oct 14, 2024

This makes the code cleaner by separating the boilerplate required as a subclass of Operation from the actual geometric calculations. It also makes the development much more convenient, as changing details in the implementation doesn't require the recompilation of the complete engine library.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 92.62295% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.47%. Comparing base (4acbca3) to head (4dd021d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/engine/SpatialJoinAlgorithms.cpp 91.81% 2 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1552      +/-   ##
==========================================
- Coverage   88.47%   88.47%   -0.01%     
==========================================
  Files         363      364       +1     
  Lines       27533    27534       +1     
  Branches     3714     3714              
==========================================
  Hits        24361    24361              
  Misses       1940     1940              
- Partials     1232     1233       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sparql-conformance
Copy link

Copy link

sonarcloud bot commented Oct 17, 2024

@joka921 joka921 changed the title Separating SpatialJoin and Algorithms for SpatialJoin into two separate classes Separate the implementation of the SpatialJoin operation into a separate class Oct 17, 2024
@joka921 joka921 merged commit 91c6184 into ad-freiburg:master Oct 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants