Add function geof:isWktPoint
#1565
Open
+31
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function returns true if and only if the argument is a WKT point. This can be checked efficiently by checking the datatype bits of the ID. Note that this function is not part of the GeoSPARQL standard. We add it because we need it for https://github.com/ad-freiburg/qlever-petrimaps to fetch alll WKT literals that are not points efficiently.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1565 +/- ##
==========================================
- Coverage 88.96% 88.96% -0.01%
==========================================
Files 366 366
Lines 33256 33268 +12
Branches 3729 3730 +1
==========================================
+ Hits 29587 29597 +10
Misses 2439 2439
- Partials 1230 1232 +2 ☔ View full report in Codecov by Sentry. |
Reason: the predicate is called `geo:asWKT`, so the new name looks more consistent with that.
Conformance check passed ✅No test result changes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function returns true if and only if the argument is a WKT point. This can be checked efficiently by checking the datatype bits of the ID.
Note that this function is not part of the GeoSPARQL standard. We add it because we need it for https://github.com/ad-freiburg/qlever-petrimaps to efficiently fetch alll WKT literals that are not points.