-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Enterprise support #108
Conversation
See
|
Hi @ad-m, I've checked on the GTE instance, if it's possible to use the API URL from the GitHub context. It's definitely the corresponding URL of the API Endpoint of the GitHub Enterprise system. |
@ad-m Done. It doesn't seem to work yet. I will look at it in detail later. |
* Update the GitHub action
Remove push command
Hi @ad-m, I've implemented the general GTE support and tested it here. I also modified the GitHub Action to check the syntax inside the PR validation itself. I also tried to execute the real push action inside the PR, but that is not possible (The tokens got not the corresponding access rights to both repositories [forked and original]). |
I wonder if instead of introducing a new parameter to the action (intended purely for development purposes), it is not enough to write in the pull request template that you should look at the builds on the "push" event on the forking repository, instead of the "pull request" event on the current repository. GitHub-hosted forks should also have GitHub Actions running, so everything audible, so I don't see any reason not to. What do you think about this simplification? |
Hi @ad-m, sounds validate. I'll modify the PR. |
Hi @ad-m, could we merge the PR? |
LGTM |
Hi @ad-m,
the corresponding draft PR is a follow-up of the last PR to include the GTE support inside the action. Could you please modify the settings of the repository to make it possible to execute the check also from a fork?
To-do: