Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy key functionality #115

Merged
merged 5 commits into from
May 4, 2022

Conversation

ZPascal
Copy link
Collaborator

@ZPascal ZPascal commented Apr 18, 2022

The corresponding PR adds in general support for the SSH Key functionality and solve the following issue.

@ad-m Could we test the first version via a dev release? I want to consume the new dev release via this test job to validate the functionality.

@ZPascal ZPascal self-assigned this Apr 18, 2022
@ZPascal ZPascal mentioned this pull request Apr 18, 2022
@ad-m
Copy link
Owner

ad-m commented Apr 26, 2022

@ad-m Could we test the first version via a dev release?

You can, but this does not make sense in GitHub Actions, because you can always use commit SHA as a version identifier.

To use a specific action version, users can configure their GitHub Actions workflow to target a tag, a commit's SHA, or a branch named for a release.

Additionally, if you create a fork and push a commit into it, you can get each commit fork through the upstream repository: https://github.com/torvalds/linux/tree/8bcab0346d4fcf21b97046eb44db8cf37ddd6da0

@ad-m
Copy link
Owner

ad-m commented Apr 26, 2022

In practice, even some security-sensitive people recommend using SHA commit versions in GitHub Actions, because the tags do not guarantee immutability (you can delete the tag and create a new one, in effect injecting the code in all consumer of actions).

@ZPascal
Copy link
Collaborator Author

ZPascal commented Apr 29, 2022

@ad-m Thanks, for detailed explanation! I’ve already tested it with the hash and everything works as expected and in I think in general the PR is now ready for a review.

@ZPascal ZPascal requested a review from ad-m April 29, 2022 21:01
Copy link
Owner

@ad-m ad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Could you rebase & self-merge?

@ZPascal ZPascal merged commit d4a6a78 into ad-m:master May 4, 2022
@ZPascal ZPascal deleted the add-deploy-key-functionality branch May 4, 2022 11:00
ZPascal pushed a commit that referenced this pull request May 4, 2022
ZPascal added a commit that referenced this pull request May 4, 2022
@ZPascal ZPascal restored the add-deploy-key-functionality branch May 4, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants