Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --force-with-lease instead of --force #80

Merged
merged 1 commit into from
May 4, 2022
Merged

Use --force-with-lease instead of --force #80

merged 1 commit into from
May 4, 2022

Conversation

imba-tjd
Copy link
Contributor

@imba-tjd imba-tjd commented Jan 26, 2021 •
edited
Loading

From my understanding, there are only benefits using --force-with-lease than --force. Correct me if I'm wrong.

@ZPascal
Copy link
Collaborator

ZPascal commented May 4, 2022

@imba-tjd I fully agree to use --force-with-lease instead of --force.

@ZPascal ZPascal merged commit f43881e into ad-m:master May 4, 2022
@ZPascal ZPascal mentioned this pull request May 5, 2022
Merged
@ZPascal
Copy link
Collaborator

ZPascal commented May 6, 2022 •
edited
Loading

Hi @imba-tjd, I've reverted the change because it's results in a bunch of issues. I think it would make sense to have such a sensitive force push functionality. I've created a separate PR that includes the functionality in a smoother way.

@ZPascal ZPascal mentioned this pull request May 6, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZPascal ZPascal ZPascal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imba-tjd @ZPascal