Ada Whales C17- Nishat Salsabil #106
Conversation
There was a problem hiding this comment.
Excellent first project, Nish! You hit the learning goals and passed all the tests. 🙂🟢
You implemented every function according to the spec; I made notes in points of improvement as well as great highlights I saw. Nice job finishing out the tests as well. Keep up the great work!
| assert updated_data["watched"][0]["title"] == MOVIE_TITLE_1 | ||
| assert updated_data["watched"][0]["genre"] == GENRE_1 | ||
| assert updated_data["watched"][0]["rating"] == RATING_1 | ||
| assert updated_data["watchlist"] == [] |
| assert updated_data["watched"][1]["title"] == movie_to_watch["title"] | ||
| assert updated_data["watched"][1]["genre"] == movie_to_watch["genre"] | ||
| assert updated_data["watched"][1]["rating"] == movie_to_watch["rating"] |
| @@ -56,10 +60,12 @@ def test_friends_unique_movies_not_duplicated(): | |||
| assert len(friends_unique_movies) == 3 | |||
|
|
|||
| # ************************************************************************************************* | |||
| # ****** Add assertions here to test that the correct movies are in friends_unique_movies ********** | |||
| assert HORROR_1 in friends_unique_movies | |||
| Return dictionary | ||
| ''' | ||
| dict = {} | ||
| if movie_title == None or genre == None or rating == None: |
There was a problem hiding this comment.
Great; this check works, though it is more customary to use is to check whether a variable is None. This article gives a good explanation.
| pp = pprint.PrettyPrinter(indent=4) | ||
|
|
||
| def create_movie(movie_title, genre, rating): | ||
| ''' |
| for friend_movie in friend_movies: | ||
|
|
||
| if friend_movie not in watched_movies: | ||
| if friend_movie in movies_not_watched_by_user: |
There was a problem hiding this comment.
You can omit this block if no action is being taken
| ''' | ||
| user_host_recs = [] | ||
| friends_list = get_friends_unique_watched(user_data) | ||
| for i in friends_list: |
There was a problem hiding this comment.
It helps to have a more descriptive variable than i!
| ''' | ||
| new_recs = [] | ||
| most_watched_genre = get_most_watched_genre(user_data) | ||
| #print(most_watched_genre) |
There was a problem hiding this comment.
Fantastic use of helper functions!
| # print("*********MY_MOVIE**********") | ||
| # print(movie) | ||
| # print("*********FRIEND_MOVIE**********") | ||
| # print(friend_movie) | ||
| # print("*********REC_MOVIE**********") | ||
| # print(rec_movies) | ||
| # print() |
There was a problem hiding this comment.
Great debugging print statements; feel free to delete when submitting
| from audioop import avg | ||
| from sys import argv |
There was a problem hiding this comment.
I don't see these libraries were used?
There was a problem hiding this comment.
Thank you Jerica for what I did well on and on area's to improve! I'm not sure what happened with the libraries? I saw they were greyed out and definitely had it in my mind to ask but soon as the tests started passing I think it completely slipped my mind! I will go back and check for this project and keep all this in mind for the future. Thank you!
No description provided.