New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reduce std::string_view creation #59

Closed

anonrig wants to merge 8 commits into main from perf-reduce-string

Member

anonrig commented Jan 16, 2023 •

edited

Loading

Before

BasicBench_AdaURL       4825 ns         4824 ns       106667 time/byte=5.97064ns time/url=438.571ns url/s=2.28014M/s

After

BasicBench_AdaURL            4478 ns         4477 ns       156362 time/byte=5.54135ns time/url=407.037ns url/s=2.45678M/s


          perf: reduce std::string_view creation

7b69dbc

anonrig requested a review from lemire

January 16, 2023 18:33


          perf: only calculate is_ascii on parse_host input

e9bd5ab

lemire reviewed

View reviewed changes

tests/wpt_tests.cpp Outdated Show resolved Hide resolved


          fix: convert string to char

51c6e0b

lemire reviewed

View reviewed changes

src/unicode.cpp Show resolved Hide resolved

lemire reviewed

View reviewed changes

src/serializers.cpp Outdated Show resolved Hide resolved

lemire reviewed

View reviewed changes

src/parser.cpp Outdated Show resolved Hide resolved

lemire reviewed

View reviewed changes

src/parser.cpp Show resolved Hide resolved

anonrig and others added 5 commits

January 16, 2023 14:13


          fix: apply recommendations

8bdd610


          We should not use std::optional.value() unless there is already a value.

1bd25f5


          fix: handle empty string on parse_host

18e9bb7


          perf: improve performance of urls ending with "/"

29ca68d


          perf: move contains_ampersand to authority state

1858af6

anonrig closed this

anonrig deleted the perf-reduce-string branch

January 22, 2023 23:57

anonrig mentioned this pull request

Add fast path to pathname start state whatwg/url#847

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet