Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPI on generic board #837

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

brentru
Copy link
Member

@brentru brentru commented Jun 3, 2024

Fixes SPI configuration for the generic OS board by adding extra detection to to the busio configure() method

@brentru brentru requested a review from makermelissa June 3, 2024 19:38
@makermelissa
Copy link
Collaborator

Looks like a formatting issue. I'll add this in a bug fix release after it passes.

@brentru
Copy link
Member Author

brentru commented Jun 3, 2024

@makermelissa I ran black across the file, should be good to go after the test passes

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good.

@makermelissa makermelissa merged commit e8e7bb1 into adafruit:main Jun 3, 2024
1 check passed
@brentru brentru deleted the fix-spi-generic-board branch June 3, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants