Add PNP ID designation to DeviceInfoService #202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
PnP ID
characteristic from the Device Information Service specification toDeviceInfoService
.Currently, there is no way to specify the Vendor ID and Product ID of the Bluetooth device using CircuitPython which can cause inconveniences when trying to make certain operating systems recognize the Bluetooth peripheral device as a specific product (e.g. an Xbox One S Wireless Controller in macOS).
The changes introduced by this PR will allow a developer to set a 8-bit value and three 16-bit values as illustrated below:
The four values being the Vendor ID source field (8-bits), Vendor ID field (16-bits), Product ID field (16-bits), and Product Version field (16-bits) respectively.