Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify to allow multiple reports in an Application collection #205

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ktnyt
Copy link
Contributor

@ktnyt ktnyt commented Oct 19, 2024

This PR removes the single report per Application Collection restriction and registers all descriptors to the HIDService.

The change should hopefully resolve #136

The following is the code I got to work on macOS Sonoma:
https://gist.github.com/ktnyt/33ad0462a0e7cc49176c78530e320291

@ktnyt ktnyt force-pushed the hid-multiple-reports branch 2 times, most recently from a3a71da to 856dc7f Compare October 19, 2024 13:21
@ktnyt ktnyt marked this pull request as draft October 19, 2024 13:24
@ktnyt ktnyt marked this pull request as ready for review October 19, 2024 14:35
@ktnyt
Copy link
Contributor Author

ktnyt commented Oct 19, 2024

I'm not sure why check-yaml fails since I haven't changed anything in the yaml files. I'll mark this PR as ready for the moment.

@ktnyt ktnyt force-pushed the hid-multiple-reports branch from 856dc7f to 04c74d4 Compare October 21, 2024 04:04
@ktnyt
Copy link
Contributor Author

ktnyt commented Oct 21, 2024

Rebasing main resolved the check-yaml issue!

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, sorry for the delay. Note that I am thinking about a restructure of the internal structure: see #207.

@dhalbert dhalbert merged commit 7c6c18f into adafruit:main Nov 13, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 19, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.7.11 from 3.7.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME680#77 from savannahcofer/bugfix/script_timeout

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 10.0.10 from 10.0.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#205 from ktnyt/hid-multiple-reports

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.10.0 from 2.9.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#76 from FoamyGuy/polygon_fill

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.2.0 from 3.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#216 from FoamyGuy/text_box

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants