Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set inital SPI CS value according to parameters #99

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Set inital SPI CS value according to parameters #99

merged 1 commit into from
Apr 9, 2024

Conversation

RetiredWizard
Copy link
Contributor

The SPIDevice initialization isn't using the passed in cs_active_value flag so for devices that use an active True chip select, the bus would be selected when the SPI device object is created rather than when it's used.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 88250a1 into adafruit:main Apr 9, 2024
1 check passed
@RetiredWizard RetiredWizard deleted the spicsinit branch April 9, 2024 17:15
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 23, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_floppy to 2.0.0 from 1.0.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_floppy#11 from adafruit/updates-incompatible-floppyio-floppsy

Updating https://github.com/adafruit/Adafruit_CircuitPython_SharpMemoryDisplay to 1.4.12 from 1.4.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_SharpMemoryDisplay#24 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermistor to 3.4.11 from 3.4.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_Thermistor#22 from adafruit/dhalbert-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 5.2.1 from 5.0.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#151 from pinkavaj/pi-fix-recv
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#157 from adafruit/core-compatible-socket-type-numbers
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#153 from us3r64/fix/socket-httpserver-poll
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#149 from pinkavaj/pi-fix-close-wait
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#156 from kevin-tritz/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 10.0.7 from 10.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#195 from adafruit/dhalbert-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 5.2.9 from 5.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#99 from RetiredWizard/spicsinit

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants