Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation of DotStar attribute #31

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

makermelissa
Copy link
Contributor

Supersedes #30. This uses the same changes in #30, but also updates workflows to Python 3.8 to match requests.

@makermelissa makermelissa requested a review from a team January 18, 2022 16:29
@makermelissa makermelissa changed the title Add documentation of DotStars attribute Add documentation of DotStar attribute Jan 18, 2022
@makermelissa makermelissa merged commit f71be29 into adafruit:main Jan 18, 2022
@davegoopot
Copy link

@makermelissa top work on getting the build to run through :)

Something has ended up not quite right with the docs though I think. I believed that the results should have ended up here: https://circuitpython.readthedocs.io/projects/funhouse/en/latest/api.html#adafruit-funhouse-peripherals

That link is showing a page with no main contents to me.

@davegoopot
Copy link

@makermelissa found the problem. Look at https://readthedocs.org/projects/adafruit-circuitpython-funhouse/builds/15808326/

Fourth step uses python3.7. Results in same problem as in the local build. I'll raise an issue.

@kattni
Copy link
Contributor

kattni commented Jan 18, 2022

@davegoopot Good catch! We're in the middle of getting a patch going to fix this across all the libraries. It should be "3.x" in .readthedocs.yaml to grab the latest.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 19, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 1.2.1 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#30 from tekktrik/doc/fix-code-block

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.6.0 from 3.5.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#150 from tekktrik/feature/configurable-eol
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#151 from tekktrik/feature/add-recvinto
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#152 from tekktrik/hotfix/fix-docs
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#149 from tekktrik/doc/add-missing-to-api

Updating https://github.com/adafruit/Adafruit_CircuitPython_FRAM to 1.3.13 from 1.3.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#33 from tekktrik/doc/update-documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.2.0 from 4.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#88 from jposada202020/including_animation_class

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 6.2.0 from 6.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#120 from FoamyGuy/force_content_type

Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.5.2 from 2.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#32 from FoamyGuy/alt_click

Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.1.10 from 2.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#33 from makermelissa/main
  > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#31 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.2.0 from 5.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#97 from goliothlabs/feat/add-binary-support

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.6.0 from 0.5.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#29 from jepler/program-object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants