Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard.py: allow 'import usb_hid' to fail #128

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Sep 8, 2024

keyboard.py unconditionally did import usb_hid. This was not necessary and prevented its being used on BLE-only boards. Thanks @ozzloy in discord for finding this.

@dhalbert dhalbert requested a review from a team September 8, 2024 17:12
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@FoamyGuy FoamyGuy merged commit d1979f5 into adafruit:main Sep 8, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 9, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.2.0 from 2.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#39 from purepani/add_temperature_compensation

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 6.1.2 from 6.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#128 from dhalbert/usb-hid-keyboard

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#66 from timchinowsky/add_pioasm_i2c_codec

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants