Server headers, FormData, some docs improvements and fix for bug in ChunkedResponse #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpokusa
changed the title
|
If possible, please test the impact of these changes to request processing speed. In theory there should not be much overhead, but in my testing I noticed a very big range (80ms-500ms). Although this might be caused by my WiFi and the connection itself, it we be great it anyone could eliminate the possibility that it is the code's fault. Thanks in advance. 🙂 |
FoamyGuy
reviewed
Jun 30, 2023
examples/httpserver_form_data.py
Outdated
| enctype = request.query_params.get("enctype", "text/plain") | ||
|
|
||
| if request.method == POST: | ||
| posted_value = request.data.get("something") |
There was a problem hiding this comment.
I got an exception here for request not having property data I think maybe this is supposed to be form_data instead?
There was a problem hiding this comment.
You are right, this should be form_data. Already fixed.
FoamyGuy
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
These changes look good to me.
I've retested all modified examples on a Feather S3 TFT with the latest versions.
Really great new functionality and improved docstrings. Thanks @michalpokusa!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 18, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.4.9 from 1.4.8: > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#26 from adafruit/ladyada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX9744 to 1.2.15 from 1.2.14: > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#17 from kbsriram/add-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_Nunchuk to 1.1.9 from 1.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_Nunchuk#31 from adafruit/stemma_i2c Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.12.0 from 3.11.3: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#114 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.14.0 from 1.13.0: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#118 from ladyada/main Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.23 from 0.5.22: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#44 from furbrain/main > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#42 from tekktrik/dev/fix-build-bundle Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.1.0 from 4.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#59 from FoamyGuy/ethernet_example > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#58 from michalpokusa/server-headers Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 3.0.10 from 3.0.9: > Merge pull request adafruit/Adafruit_CircuitPython_NTP#30 from joshua-beck-0908/timezone_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.14.9 from 1.14.8: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#92 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR does not contain any breaking changes, I suggest publishing it as 4.1.0.
⭐ Added:
FormDataclass andRequest.form_datafor parsing POST body for"application/x-www-form-urlencoded","multipart/form-data","text/plain"content types.Server.headersfor setting headers that are sent with every response, without need for explicitly adding them in constructor.Server.poll()return value that indicates the result of polling e.g.NO_REQUESTorREQUEST_HANDLED_RESPONSE_SENT.🛠️ Updated:
ChunkedResponsesending empty chunk was breaking functionality, because it ended response prematurely.Server.stoppedis set toTruein constructor, it changes toFalseonly after calling.start().server_forever().🏗️ Refactor:
query_paramsandform_datato use_IFieldStoragefor shared functionality.