Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS implementation #88

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

michalpokusa
Copy link
Contributor

@michalpokusa michalpokusa commented Feb 23, 2024

Depends on #84, #87 and adafruit/circuitpython#9003

⭐ Added:

🛠️ Updated/Changed:

  • Server constructor now accepts https, certfile and keyfile args that together enable HTTPS
  • In debug mode, time it took server to handle the request is now measured from before .accept(), which includes the time of handling TLS decryption, thus the time is more "correct"
  • Docs now include info about HTTPS

🏗️ Refactor:

  • Some parts of docs that used to have bolded paragraphs not have them in Sphinx's notes

After fixing the issues mentioned at the top, this code should also work on other platforms than ESP32-S3.

@dhalbert
Copy link
Contributor

@michalpokusa I'm sorry we missed merging this. Is it ready to go? Any retesting needed since various other library changes? Thanks.

@michalpokusa
Copy link
Contributor Author

@michalpokusa I'm sorry we missed merging this. Is it ready to go? Any retesting needed since various other library changes? Thanks.

No problem. I didn't push on merging this as although this works (or did when I marked it as ready) on ESP32-S3, it is not compatible with RPico, S2 etc. Recently there were also some changes to the SSL module on CircuitPython, so I was waiting on how things play out.

I am not sure whether the MemoryError is fixed on other MCUs or if there are plans to resolve them in future.

Meanwhile this PR can be merged as is or I could add a warning that prints info about compatibility or checks the board id, or I can convert it to draft for now. Please tell me what would be best in your opinion.

Retest is always good, if you decide to merge I will do it with latest CircuitPython.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants