Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10MHz Crystal Lookup Table added, improved crystal validity check #17

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

HeCoding180
Copy link
Contributor

@HeCoding180 HeCoding180 commented Jan 24, 2023

CNF[1:3] register lookup table has been extended and now additionally features a lookup table for a 10MHz crystal oscillator.
Crystal oscillator validity check is now more redundant, since it gets the valid crystal oscillator frequencies directly from the baud rates dictionary

@tannewt tannewt requested a review from a team January 25, 2023 17:44
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@tekktrik tekktrik merged commit 02b71aa into adafruit:main Jan 27, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 27, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.1.0 from 1.0.19:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP2515#17 from HeCoding180/10MHz-Crystal-Add
  > Add upload url to release action

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT31D to 2.3.21 from 2.3.20:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#34 from chriswwind/patch-1
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants