Add rotate() to change rotation after init #54
Conversation
|
@radiac thanks for adding this functionality! The actions checks automatically run pylint and it has flagged a few lines as being a little bit too long. The output of the checks that indicates which lines can be seen here: https://github.com/adafruit/Adafruit_CircuitPython_MacroPad/actions/runs/7853447347/job/21433071528?pr=54 or if you'd like you can follow this guide page: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code to setup pre-commit so that you can run the checks locally beforehand. When you have a sec can you add another commit on this branch that re-arranges the text in those lines to be less than the pylint limit? |
|
Sorry, totally missed you were on 100 char line lengths and had pre-commit there. Think that should be sorted now, thanks! |
There was a problem hiding this comment.
This looks good to me. Nice functionality thanks @radiac!
I added tweak with a new commit to add a setter for the rotation propertery so now you can use the sytanx macropad.rotation = 90.
I tested it successfully on a device with a modified version of the rotation example in the repo.
Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 2.4.0 from 2.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#54 from radiac/feature/change_rotation Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
I'm writing a script which needs to change the rotation of an existing MacroPad instance.
I have refactored the
__init__method to move the rotation code out into a newrotate(rotation)method; this is called by__init__so existing functionality is unaffected, but the new method allows the rotation to be changed after initialisation. I also added arotationproperty to check the current rotation.