Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timeout Exception #163

Merged
merged 1 commit into from
May 21, 2024

Conversation

justmobilize
Copy link
Collaborator

This removes the custom timeout Exception that makes this socket library behave like CPython versions pre 3.10 and updates it to behave like espressif and pico-w.

This matches the PR for ESP32SPI: adafruit/Adafruit_CircuitPython_ESP32SPI#206

@justmobilize
Copy link
Collaborator Author

@dhalbert similar update

@justmobilize justmobilize marked this pull request as ready for review May 21, 2024 14:55
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit 66ffd0b into adafruit:main May 21, 2024
1 check passed
@justmobilize justmobilize deleted the remove-timeout-exception branch May 21, 2024 16:29
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 22, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 8.3.0 from 8.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#206 from justmobilize/remove-timeout-exception
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#205 from justmobilize/remove-socket-pool-contants

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 7.1.1 from 7.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#162 from justmobilize/remove-socket-pool-contants
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#163 from justmobilize/remove-timeout-exception

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.8.1 from 7.8.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#217 from justmobilize/update-comments

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants