fix hardcoded pulse limits #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and µs functions use our return µs
and removed hoardcoded pulse cycle limits
|
@ichbtm thank you very much for your help, somehow this issue fall off our radar until recently :( |
|
@ichbtm there is a new push that fix the incorrect freq due to a bug in PWM module. Thank you again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As notified there #68 :
Your implementation use hardcoded pulse limits and doesn't use user's values given to the attach function.
In addition, microseconds functions doesn't use ou return a µs value.
I had to modify the type of min and max parameters to allow storage of values up to 2500µs... maybe it had would be better to add new params (ex : minus and maxus) to avoid confusion with other ARCH...