Add availableForWrite method to Serial. #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
requested changes
Jul 27, 2019
| @@ -190,6 +190,11 @@ bool tud_cdc_n_write_flush (uint8_t itf) | |||
| return true; | |||
| } | |||
|
|
|||
| uint32_t tud_cdc_n_availableForWrite (uint8_t itf) | |||
There was a problem hiding this comment.
- I think
tu_fifo_remaining()is a better way to implement this. Would you mind changing it - Also please rename the function to
tud_cdc_n_write_available(), the stack uses all lower cases convention.
There was a problem hiding this comment.
I have made the requested changes in a 2nd commit.
rename low level CDC functions to tud_cdc_n_write_available and tud_cdc_write_available
hathach
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add availableForWrite method to Serial
Compatible with the standard Arduino API. This will apply cleanly on top of the fix_serial patch.