Fix multiple warnings when building. #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #1: warning: format '%X' expects argument of type 'unsigned int', but argument 3 has type 'int32_t {aka long int}' [-Wformat=] The C++ specification requires "%X" to receive an unsigned value. Any other type (including signed values) is "undefined behavior". Fix #2: warning: narrowing conversion of '(((int)itfnum) + 1)' from 'int' to 'uint8_t {aka unsigned char}' inside { } [-Wnarrowing] The affected macros are returning a list of uint8_t values, typically to define statically-allocated byte arrays. The fix is to explicitly cast to `uint8_t` when doing arithmetic on any parameter. Also added explicit comment on the implied constraint.
hathach
approved these changes
Aug 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two types of warnings fixed.
First warnings:
warning: format '%X' expects argument of type 'unsigned int', but argument 3 has type 'int32_t {aka long int}' [-Wformat=]
The C++ specification requires "%X" to receive an unsigned value. Any other type (including signed values) is "undefined behavior".
Second set of warnings:
warning: narrowing conversion of '(((int)itfnum) + 1)' from 'int' to 'uint8_t {aka unsigned char}' inside { } [-Wnarrowing]
Affected macros were returning a list of uint8_t values, used to define statically-allocated byte arrays. Fixed by explicitly casting to
uint8_twhen doing arithmetic on any parameter. Notation also added to call out implied range constraint on the parameter _itfnum.