Patch 1 - fix pipe errors on write(), fix write() return for println(), turn off BLE_RW_DEBUG #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NBP (2/21/2015): Modified to fix pipe errors on Adafruit_BLE_UART::write()
pipe error 0x91 "ACI_STATUS_ERROR_CREDIT_NOT_AVAILABLE"
* write() added check of aci_state.data_credit_available along with lib_aci_is_pipe_available()
before calling lib_aci_send_data() -- credit was going below 0 (wrap around to 255)
* Added missing break in pollACI() after case ACI_EVT_CONNECTED block.
* pollACI() case ACI_EVT_PIPE_ERROR removed credit increment, let ACI_EVT_DATA_CREDIT do it.
* write() removed delay(35), not needed with credit check fixes.
Seems to also reduce transmission losses -- allows for more pollACI() calls (?)
len -= bytesThisPass; // NBP (2/22/2015) fix for return value, no break, also fixes println()
neilsunw
changed the title
|
Thanks for the pull request ... I'll have to properly test this out before we can merge it, but it looks good browsing the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pipe errors on write() -- error 0x91-- credit tracking fixes
Removed delay(35) in write() -- not needed with credit checking
Fix write(buffer,len) return code -- fixes println()
Turned off BLE_RW_DEBUG