Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix py build not using created temp file #115

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Fix py build not using created temp file #115

merged 1 commit into from
Mar 3, 2024

Conversation

justmobilize
Copy link
Contributor

In the PR https://github.com/adafruit/circuitpython-build-tools/pull/101/files, the code in build.library was simplified, but in the case of the py file (not mpy) the original file was copied, not the temp file with the updated version

@justmobilize
Copy link
Contributor Author

@dhalbert I only tested this locally with creating a single library and checking that the file had the correct version

@justmobilize justmobilize marked this pull request as ready for review March 3, 2024 22:00
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you.

@dhalbert dhalbert merged commit 4f7f0b8 into adafruit:main Mar 3, 2024
1 check passed
@justmobilize justmobilize deleted the fix-py-build branch March 3, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants