Change multipathServiceType to none #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for spotting this @chickdan. Haven't come across this issue myself. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 89.15% 89.15%
=======================================
Files 198 198
Lines 2721 2721
=======================================
Hits 2426 2426
Misses 295 295 ☔ View full report in Codecov by Sentry. |
adamayoung
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried out this SDK for the first time today but spent hours trying to determine why I wasn't getting a response. Drilling down I came across
configuration.multipathServiceType = .handover. I was curious what that is since I have not used it before and reading the docs I saw that it Requires the com.apple.developer.networking.multipath entitlement.Using these service types requires the appropriate entitlement. Any connection attempt will fail if the process does not have the required entitlement.
This explained all of my problems and confirmed as such with the change of this PR.
My suggestion, given this SDK will likely be most used by developers working on hobby projects, is to switch this to
.noneso that the entitlement is not required. However, if this setting is a hard requirement for the SDK I can change this PR to instead emphasize the need for the entitlement in the README.