Cleanup from my prior changes #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 89.38% 89.47% +0.09%
==========================================
Files 201 201
Lines 2807 2804 -3
==========================================
Hits 2509 2509
+ Misses 298 295 -3 ☔ View full report in Codecov by Sentry. |
adamayoung
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessarily setting url session configuration
multipathServiceType = .nonedue to being the default value.Unrelated to this change but I noticed
@available(macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0, *)is throughout the codebase but these match the versions specified inpackage.swiftso the compiler already catches any discrepancies. How do you feel about their removal? I can take care of that in this PR and reduce a bit of future maintenance.