Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: TVShow Content Ratings #188

Merged
merged 14 commits into from
Jul 16, 2024

Conversation

chickdan
Copy link
Contributor

Adding support for this endpoint

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.47%. Comparing base (868a1ad) to head (68c3e1d).

Files Patch % Lines
...MDb/Domain/Services/TVSeries/TVSeriesService.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   89.47%   89.47%   -0.01%     
==========================================
  Files         201      203       +2     
  Lines        2804     2822      +18     
==========================================
+ Hits         2509     2525      +16     
- Misses        295      297       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamayoung
Copy link
Owner

Hey @chickdan - just need to add a few more tests to bump the code coverage of your changes about 60% 🙏🏻

@chickdan
Copy link
Contributor Author

chickdan commented Jul 16, 2024

@adamayoung thank you for your patience. I've expanded the test coverage for this feature, although I'm not sure why TVSeriesService.swift is reporting as two lines not covered when I added an integration test. That said, it looks like watchProviders() has the same issue.

@adamayoung adamayoung merged commit 08094ce into adamayoung:main Jul 16, 2024
16 checks passed
@chickdan chickdan deleted the tvshow_content_ratings branch July 16, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants