Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: protocol for TMDbAPI #21

Merged
merged 2 commits into from
Sep 25, 2020
Merged

FEATURE: protocol for TMDbAPI #21

merged 2 commits into from
Sep 25, 2020

Conversation

adamayoung
Copy link
Owner

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #21 into main will decrease coverage by 3.42%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   92.04%   88.62%   -3.43%     
==========================================
  Files          63       64       +1     
  Lines         918      958      +40     
==========================================
+ Hits          845      849       +4     
- Misses         73      109      +36     
Impacted Files Coverage Δ
Sources/TMDb/MovieTVShowAPI.swift 0.00% <0.00%> (ø)
Sources/TMDb/TMDbAPI.swift 100.00% <ø> (ø)
Sources/TMDb/DTOs/PersonDTO.swift 100.00% <100.00%> (ø)
Sources/TMDb/DTOs/StillURLProviding.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299b895...80ee81f. Read the comment docs.

@adamayoung adamayoung merged commit d8edc5b into main Sep 25, 2020
@adamayoung adamayoung deleted the features/api-protocol branch September 25, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant