Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ESLint 6 #235

Merged
merged 7 commits into from
Jun 28, 2019
Merged

Upgrade to ESLint 6 #235

merged 7 commits into from
Jun 28, 2019

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Apr 13, 2019

To upgrade to eslint 6 the following had to be changed:

  • ESLint 6 drops support Node for 6, so I updated .travis.yml to only run for Node >=8.10.0.
  • linter.options.ignore -> linter.isPathIgnored(filePath)
  • unknown plugin error message changed, so one test had to be updated
  • tests use file paths internal to eslint (for the formatters). Those had to be updated.

@coveralls
Copy link

coveralls commented Apr 13, 2019

Coverage Status

Coverage remained the same at 99.31% when pulling f079235 on ehmicky:feature/eslint-v6 into 40d004f on adametry:master.

@ehmicky
Copy link
Contributor Author

ehmicky commented Jun 23, 2019

Tests are now passing on CI.

@shinnn

@onigoetz onigoetz mentioned this pull request Jun 24, 2019
2 tasks
@shinnn
Copy link
Collaborator

shinnn commented Jun 28, 2019

@ehmicky Would you be interested in joining the project as a maintainer? I’ve been impressed with your continuous contributions on execa, and unfortunately I don’t have enough motivation to maintain this project as I personally no longer use gulp.

Copy link
Collaborator

@shinnn shinnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful if you update CHANGELOG.md in this PR. We can do it later, though.

@ehmicky
Copy link
Contributor Author

ehmicky commented Jun 28, 2019

I've fixed the CHANGELOG.

Thanks for the invitation (and your mention of my work on execa)! I am very interested in both ESLint and Gulp. However right now I am working on too many projects at the same time, so I'm not sure whether I should add another one to maintain. Could this invitation extend to the future, where I might have fewer projects to work on?

@shinnn
Copy link
Collaborator

shinnn commented Jun 28, 2019

Could this invitation extend to the future, where I might have fewer projects to work on?

Sure. I appreciate your kind response!

For now I’m merging this and will publish a new version by myself.

@shinnn shinnn merged commit a35a203 into adametry:master Jun 28, 2019
@ehmicky ehmicky deleted the feature/eslint-v6 branch June 28, 2019 16:52
@shinnn
Copy link
Collaborator

shinnn commented Jun 28, 2019

https://github.com/adametry/gulp-eslint/releases/tag/v6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants