Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add base64 image support #60

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Add base64 image support #60

merged 1 commit into from
Oct 23, 2017

Conversation

gidztech
Copy link
Contributor

adamgruber
adamgruber approved these changes Oct 23, 2017
View reviewed changes
Copy link
Owner

@adamgruber adamgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good.

@adamgruber adamgruber merged commit 4278e4c into adamgruber:master Oct 23, 2017
@adamgruber adamgruber mentioned this pull request Oct 23, 2017
Closed
@gidztech
Copy link
Contributor Author

Cool thanks. Looking forward to having my VRT screenshots in test reports once you hit the magic release button.

@adamgruber
Copy link
Owner

@gidztech 2.3.0 released. Thanks again 👍

@gidztech
Copy link
Contributor Author

gidztech commented Oct 23, 2017 •
edited
Loading

@adamgruber It looks like something has gone wrong with the release. I'm getting TypeError: marge.getBaseConfig is not a function.

If I run npm run dist (side note: after disabling eslint - seems to be few arrow function assignments), the compiled main.js in lib (and possibly the others) is different from the one output in the release package.

Perhaps you built the release package from a different branch from master ?

@adamgruber
Copy link
Owner

@gidztech Sorry for the botched release. I published 2.3.1 which should be ok. There was some lint and I forgot to run build before publishing. That'll teach me to release stuff after a long day.

@gidztech
Copy link
Contributor Author

@adamgruber No problem. Working great now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgruber adamgruber adamgruber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gidztech @adamgruber