Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZIP: Use last modified time from basic header when validating zip decryption #804

Closed
DannyBoyk opened this issue Jan 26, 2024 · 0 comments · Fixed by #805
Closed

ZIP: Use last modified time from basic header when validating zip decryption #804

DannyBoyk opened this issue Jan 26, 2024 · 0 comments · Fixed by #805

Comments

@DannyBoyk
Copy link
Contributor

When support was added for the UnixTimeExtraField a little while ago, zip decryption validation was broken if a zip is encrypted and has UnixTimeExtraFields present. The zip encryption uses the basic header's last modified time value and not the times from the UnixTimeExtraField.

PR to fix incoming.
DannyBoyk added a commit to DannyBoyk/sharpcompress that referenced this issue Jan 26, 2024
@DannyBoyk
Zip: Use last modified time from basic header when validating zip dec…
14c9735 
…ryption

The last modified time used for zip decryption validation must be the
one from the basic header. If UnixTimeExtraFields are present, the
previous implementation was attempting to verify against that value
instead.
Fixed adamhathcock#804
@DannyBoyk DannyBoyk mentioned this issue Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Zip: Use last modified time from basic header when validating zip decryption DannyBoyk/sharpcompress
1 participant
@DannyBoyk