Skip to content

Commit

Permalink
Add log warn message about possibly malformed run URLs
Browse files Browse the repository at this point in the history
Signed-off-by: Alec Hinh <alec.hinh@zapier.com>
  • Loading branch information
ahinh43 committed Aug 7, 2023
1 parent f09701d commit 9e80812
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/vcs/github/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ func (c *Client) GetOldRunUrls(prID int, fullName string, rootCommentID int) (st
// We set the ID and URL to the run URL as a fallback (as it was originally scraped)
// It'll appear like this in markdown
// [https://app.terraform.io/...](https://app.terraform.io/...)
log.Warn().Msg("Unable to obtain Terraform cloud run ID. The run URL(s) on the previous comments may be malformed.")
runID = runUrl
runUrlRaw = runUrl
}
Expand Down
1 change: 1 addition & 0 deletions pkg/vcs/gitlab/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ func (c *GitlabClient) GetOldRunUrls(mrIID int, project string, rootNoteID int)
// We set the ID and URL to the run URL as a fallback (as it was originally scraped)
// It'll appear like this in markdown
// [https://app.terraform.io/...](https://app.terraform.io/...)
log.Warn().Msg("Unable to obtain Terraform cloud run ID. The run URL(s) on the previous comments may be malformed.")
runID = runUrl
runUrlRaw = runUrl
}
Expand Down

0 comments on commit 9e80812

Please sign in to comment.