Fix minor issues in purchasing and courier #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JoshdanG
commented
Jul 23, 2023
•
JoshdanG
commented
- Refactor ItemPurchaseExtend to always call UseCourier
- Avoids bugs where function exits early and forgets to call UseCourier
- Courier should not wait to purchase items that are not purchased at secret shop
- Do not buy within UseCourier; it is redundant and missing features like removing from the purchase list.
- Don't buy from fountain shop when stash is full
- Prevents dropping items on the ground when buying too much
- Set sNextItem to "Out_of_items" when there are no more items
- Helps debugging and may prevent multiple buys of final item
Avoids bugs where function exits early and forgets to call UseCourier
1. Don't wait to purchase items that are not purchased at secret shop 2. Do not buy within UseCourier; it is redundant and missing features like removing from the purchase list.
Prevents dropping items on the ground when buying too much
Helps debugging and may prevent multiple buys of final item
adamqqqplay
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.