replace default pre-release phase with default pre-release identifiers #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamralph
force-pushed
the
default-pre-release-identifiers
branch
from
c90edf8 to
8c478a5
Compare
adamralph
force-pushed
the
default-pre-release-identifiers
branch
from
8c478a5 to
8276d73
Compare
adamralph
force-pushed
the
default-pre-release-identifiers
branch
from
8276d73 to
7f2ea07
Compare
|
@iampluque @lonix1 with reference to #796, I've released this in 4.3.0-beta.1. Please feel free to give it a try. |
This was referenced Mar 17, 2023
Merged
ivarne
added a commit
to Altinn/app-lib-dotnet
that referenced
this pull request
Oct 16, 2023
adamralph/minver#839 MinVerDefaultPreReleasePhase -> MinVerDefaultPreReleaseIdentifiers
ivarne
added a commit
to Altinn/app-lib-dotnet
that referenced
this pull request
Oct 26, 2023
adamralph/minver#839 MinVerDefaultPreReleasePhase -> MinVerDefaultPreReleaseIdentifiers
ivarne
added a commit
to Altinn/app-lib-dotnet
that referenced
this pull request
Nov 13, 2023
* MinVer update adamralph/minver#839 MinVerDefaultPreReleasePhase -> MinVerDefaultPreReleaseIdentifiers * Don't warn for [Obsolete] api usage or missing XML doc in test projects * Enable nullable in options controller The `[FromQuery]` `?language=` parameter was optional without nullable reference types, but now became required causing a `BadRequest` in tests. It was not decorated as nullable, so a quick fix is to supply a default value of "nb". Other potential resolutions would be * Update the interface so that language is declared nullable for IAppOptionsProvider * Change the public app API, so that language becomes a required get parameter. * Fix all the easy nullability warnings in Controllers Note that enabeling nullable on controllers makes non nullable parameters required and causes additional BadRequest responses * Change behaviour of SecretsLocalClient to throw exception like the client backed by KeyVault * Fix nullability warnings in MulipartRequestReader * Update sonarColud comment * Declare DataController with [ApiController] to automatically trigger bad request Also add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case(s)
When the default pre-release identifiers,
alpha.0, which are used to version post-RTM commits which are not tagged with a version, do not match the desired pre-release identifier conventions. For example, the desired conventions may not allow foralpha.1as the initial pre-release or they may have a different number of identifiers.Description
By setting
MinVerDefaultPreReleaseIdentifiers, you can change the default pre-release identifiers fromalpha.0, to something else, such aspreview.0, orpreview.0.0.E.g.
Alternatives
1.0.0RTM tag with1.0.0-preview.0.0.Additional context
See #796 (reply in thread).
MinVerDefaultPreReleaseIdentifierssupersedesMinVerDefaultPreReleasePhase, which has been deprecated, and will be removed in the next major version.