Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 978952 - stand up trivial mocha/chai unit test #4

Merged
merged 1 commit into from
Mar 4, 2014

Conversation

dmose
Copy link
Collaborator

@dmose dmose commented Mar 3, 2014

A trivial unit test so that people can start writing tests with their JavaScript code. Paired by @n1k0 and @dmose.

@Standard8
Copy link
Collaborator

Would be good to get a readme file (at least for now) about how to run the tests.

@Standard8
Copy link
Collaborator

Also needs the bug number adding to the commit message and the PR title

@@ -0,0 +1,9 @@
var expect = chai.expect;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: double space

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@Standard8
Copy link
Collaborator

Both the vendor/mocha-* files are marked as executable when they don't need to be.

@dmose
Copy link
Collaborator Author

dmose commented Mar 4, 2014

Fixed the modes on the mocha files.

dmose pushed a commit that referenced this pull request Mar 4, 2014
Bug 978952 - stand up trivial mocha/chai unit test, patch=n1k0, dmose; r=Standard8
@dmose dmose merged commit 051903c into master Mar 4, 2014
@dmose dmose deleted the loop-mocha-unit-tests branch March 4, 2014 04:36
adamroach pushed a commit that referenced this pull request Sep 17, 2014
Added tests steps to verify amount of ICE connections with or without SDP bundle support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants