#32 - Add check for empty value #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,6 +134,10 @@ public function _wp_save_revisioned_meta_fields( $revision_id ) { | |||
| foreach ( $this->_wp_post_revision_meta_keys() as $meta_key ) { | |||
| $meta_value = get_post_meta( $post_id, $meta_key ); | |||
|
|
|||
| if ( empty( $meta_value ) ) { | |||
There was a problem hiding this comment.
if someone clears meta, we need to save that state in a revision, this would prevent that.
adamsilverstein
requested changes
Aug 14, 2017
|
Hey @adamsilverstein forgot this was open, created this with the original ticket. I'll close this for now, untill i get a change to add the filter but thanks for taking a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32 - Prevent the creation of empty meta keys that didn't exist on the copied post, but exist in the whitelist, this wont stop an empty key from being copied.