Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to apollo-boost #38

Merged
merged 1 commit into from
May 22, 2019
Merged

migrate to apollo-boost #38

merged 1 commit into from
May 22, 2019

Conversation

ascott1
Copy link
Contributor

@ascott1 ascott1 commented May 22, 2019

👋 @adamsoffer. Thanks for this great package. I'm teaching React/Next & GraphQL and find the use of this package to be much easier for students to understand than the HOC in the official next examples.

This should address #23 by migrating from the deprecated apollo-client-preset to apollo-boost.

@adamsoffer
Copy link
Owner

Thanks @ascott1. Appreciate the kind words and great knowing this will help your students.

PR looks great. Merging now.

p.s. I'm from New Haven as well 🙌

@adamsoffer adamsoffer merged commit b9b1f51 into adamsoffer:master May 22, 2019
@ascott1
Copy link
Contributor Author

ascott1 commented May 22, 2019

p.s. I'm from New Haven as well 🙌

Small world! I'm currently using this library when building out the web app for my next O'Reilly book. I would love to chat sometime.

@ascott1
Copy link
Contributor Author

ascott1 commented May 22, 2019

@adamsoffer I thought this was a simple 1:1 dependency swap, but it looks like it causes issues with all of the example implementations. I haven't had a chance to dig in too much, but my theory is that it's caused by apollo-boost's different configuration options.

In the meantime it might be better to roll this back and look at importing the packages individually, rather than via boost. Sorry!!!

@adamsoffer
Copy link
Owner

Seems like this is actually a bug in apollo-boost. I downgraded and froze the apollo-boost dep to 0.3.1 and confirmed it works with the next-apollo-example now :) Thanks again.

Small world! I'm currently using this library when building out the web app for my next O'Reilly book. I would love to chat sometime.

That book looks awesome! Would love to chat. You should come through the Digital Surgeons office sometime at District :) My email is adam @ soffer dot dev

@ascott1
Copy link
Contributor Author

ascott1 commented May 23, 2019

Ah, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants