Skip to content
This repository has been archived by the owner on Jul 21, 2020. It is now read-only.

Modify project plist for decorated icons during build time #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kudo
Copy link

@Kudo Kudo commented Oct 28, 2014

Hi,

iOS-Build-Kit is nice especially for the decorated icons feature.
However, original design of the usage is to add decorated icons in project plist.
To fulfill both these cases, the manual settings at project plist might not be a good idea.

  1. Formal build from buildkit with decorated icon
  2. Testing build from Xcode GUI without decorated icon,

Sometimes I will get a empty app icon due to decorated icon did not generated in Xcode GUI.

The PR is to modify the strategy that modify project plist with the decorated icons at build time.
Please help to see if this change makes sense.

Forgive that I am not quite familiar with Ruby, and I did not update the document and example project.
If there are any further changes need to do, please let me know.
Thanks and looks forward to seeing iOS-Build-Kit to be better and better.
Kudo

@adamwaite
Copy link
Owner

Thanks for this. I'll come round to it when I get time.

@Kudo
Copy link
Author

Kudo commented Oct 30, 2014

Thanks and take your time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants