-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android example version compatibility #1603
Conversation
The proto file update is a possible fix but testing still needs to be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just two small comments!
examples/android/client/app/src/main/java/flwr/android_client/MainActivity.java
Outdated
Show resolved
Hide resolved
examples/android/client/app/src/main/java/flwr/android_client/MainActivity.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, great to have this updated to 1.0+!
What does this implement/fix? Explain your changes.
Makes this example compatible with the versions
>=1.0.0
offlwr
.The code of the android app needs an update also, as currently there is the following issue: #1388