Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup-envs.sh script to remove crashes #1609

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Fix setup-envs.sh script to remove crashes #1609

merged 4 commits into from
Jan 24, 2023

Conversation

charlesbvll
Copy link
Member

What does this implement/fix? Explain your changes.

It adds a default case to the case statement and only compare the basename of $SHELL.

Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank you!

@tanertopal tanertopal enabled auto-merge (squash) January 24, 2023 18:06
@tanertopal tanertopal merged commit 1fbd466 into main Jan 24, 2023
@tanertopal tanertopal deleted the fix-setup-envs branch January 24, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants