Isolate ClientManager in the streaming gRPC stack #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the Driver API dependency on the
ClientManageris dropped. Going forward, the streaming gRPC stack is the only component that relies onClientManager, other transport stacks (e.g. REST) will be able to run without it.The dependency on
ClientManageris dropped by keeping a record about available client nodes (node IDs) in theDriverState(instead of having theDriverServicerread this directly from theDriverClientManager). Other transport stacks (e.g., REST) will be able to register client nodes with theDriverStatein the same way.Disentangling Driver API (
DriverServicer) andDriverClientManageris an important step to eventually have Driver API and Fleet API run in different processes, maybe even on different machines.