Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPS to REST API #1770

Merged
merged 59 commits into from
Apr 19, 2023
Merged

Add HTTPS to REST API #1770

merged 59 commits into from
Apr 19, 2023

Conversation

charlesbvll
Copy link
Member

What does this implement/fix? Explain your changes.

Gives the possibility to start the fleet API server with an SSL certificate in order to connect via HTTPS.

src/py/flwr/server/app.py Outdated Show resolved Hide resolved
src/py/flwr/server/app.py Outdated Show resolved Hide resolved
@charlesbvll charlesbvll marked this pull request as ready for review April 12, 2023 16:41
…s-rest

* 'add-https-rest' of github.com:adap/flower:
  Update src/py/flwr/client/rest_client/connection.py
  Update src/py/flwr/client/app.py
  Update src/py/flwr/client/app.py
  Update src/py/flwr/client/grpc_client/connection.py
  Update src/py/flwr/client/app.py
  Update src/py/flwr/client/app.py
  Update src/py/flwr/client/app.py
  Make other packages' spacing consistent (#1799)
src/py/flwr/server/app.py Outdated Show resolved Hide resolved
src/py/flwr/server/app.py Outdated Show resolved Hide resolved
src/py/flwr/server/app.py Outdated Show resolved Hide resolved
tanertopal and others added 6 commits April 18, 2023 15:56
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
* main:
  Improves shutdown when background thread fails (#1794)
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danieljanes lgtm and can be merged from my point of view.

@tanertopal tanertopal enabled auto-merge (squash) April 19, 2023 13:27
@tanertopal tanertopal merged commit ad9bc60 into main Apr 19, 2023
@tanertopal tanertopal deleted the add-https-rest branch April 19, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants