-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTPS to REST API #1770
Merged
Merged
Add HTTPS to REST API #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
requested changes
Apr 11, 2023
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
tanertopal
reviewed
Apr 13, 2023
danieljanes
reviewed
Apr 17, 2023
danieljanes
reviewed
Apr 18, 2023
danieljanes
reviewed
Apr 18, 2023
…s-rest * 'add-https-rest' of github.com:adap/flower: Update src/py/flwr/client/rest_client/connection.py Update src/py/flwr/client/app.py Update src/py/flwr/client/app.py Update src/py/flwr/client/grpc_client/connection.py Update src/py/flwr/client/app.py Update src/py/flwr/client/app.py Update src/py/flwr/client/app.py Make other packages' spacing consistent (#1799)
danieljanes
reviewed
Apr 18, 2023
danieljanes
requested changes
Apr 18, 2023
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
* main: Improves shutdown when background thread fails (#1794)
tanertopal
reviewed
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danieljanes lgtm and can be merged from my point of view.
danieljanes
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Gives the possibility to start the fleet API server with an SSL certificate in order to connect via HTTPS.