Fix the baseline template docstrings #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-narozniak
requested review from
pedropgusmao,
jafermarq,
tanertopal and
danieljanes
as code owners
|
looks good to me! |
jafermarq
approved these changes
Jun 30, 2023
tanertopal
approved these changes
Jul 4, 2023
tanertopal
added a commit
that referenced
this pull request
Jul 5, 2023
* main: Remove line with typo from script (#2001) Fix simulation error caused by Pydantic version in Ray (#2002) Update mxnet examples dependency versions (#1982) Update torch version in pyproject.toml files (#1993) Update tensorflow examples dependency versions (#1984) Fix the baseline template docstrings (#1983) Fix Baselines CI PyLint error by using Resampling (#1998) Make tensorflow optional when using tensorboard (#1879) Update dependencies for MXNet example (#1988) Fix `starlette` vulnerability (#1992) Fix vulnerability detected by Dependabot (#1990) Fix dependabot critical errors (#1989) Add Ruff UP check (#1946) Update torch examples dependency versions (#1981) Remove && from the end of lines in test.sh (#1979) Baselines docs updates (#1977) Fixes GitHub CI issue because of behaviour change (#1976)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The template for baselines has comments at the top of the files instead of docstrings. It makes the tests that have to be added fail.
Description
NA
Related issues/PRs
NA
Proposal
Change the comments to docstrings that meet the future test requirements.
Description
Fix: